docs: weekly review 2026-05-21#130
Open
vasylenko wants to merge 1 commit into
Open
Conversation
…fra adapters list The filesystem access for bear-add-file (readAttachmentFile) is implemented inline in src/tools/note-tools.ts, not as a separate adapter in src/infra/. The only external system adapters in src/infra/ are SQLite (database.ts) and the Bear URL scheme (bear-urls.ts).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates project documentation to remove an incorrect claim about a non-existent filesystem adapter in src/infra/, keeping the architecture overview aligned with the actual codebase structure.
Changes:
- Removed “filesystem” from the list of external-system adapters purported to live in
src/infra/inCLAUDE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The weekly documentation review found one factual inaccuracy in
CLAUDE.md: the Source Layout section listed "filesystem" as an external system adapter living insrc/infra/, but no such adapter exists there. The filesystem access forbear-add-file(readAttachmentFile) is implemented inline insrc/tools/note-tools.ts. The only external system adapters insrc/infra/are the SQLite adapter (database.ts) and the Bear URL scheme adapter (bear-urls.ts).Changes
(SQLite, filesystem, Bear URL scheme)adapters live ininfra/; removedfilesystemfrom the list since no filesystem adapter exists insrc/infra/(readAttachmentFileis insrc/tools/note-tools.ts)No Issues Found
The following checklist areas were verified accurate:
REVISION_POLL_TARGET_MS,POLL_TIMEOUT_MS,database.ts:59, system test attests/system/registration-gate.test.ts,src/infra/bear-schema.test.tsFTS5 guard)UI_DEBUG_TOGGLE,UI_ENABLE_NEW_NOTE_CONVENTION,UI_ENABLE_CONTENT_REPLACEMENT) correctly documented in README.md, NPM.md, manifest.json, and websitepackage.json; install commands verified; database path (~/Library/Group Containers/...) matchesdatabase.tsGenerated by Claude Code