Skip to content

enhancement(encode_proto): When encoding values into string fields, attempt to convert them automatically #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 3, 2025
Merged

enhancement(encode_proto): When encoding values into string fields, attempt to convert them automatically #1304

merged 6 commits into from
Mar 3, 2025

Conversation

@roykim98
Copy link
Contributor

@roykim98 roykim98 commented Mar 1, 2025 •
edited
Loading

Summary

Similar to #1114, encode values to string fields by converting values of bool, int, and float under the hood. This is an operation that fails currently.

Also decodes test.desc such that a test.proto is included alongside the other existing test*.proto and test*.desc in case it needs to be updated in the future.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Unit tests

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

@pront pront changed the title fix(encode_proto): When encoding values into string fields, attempt to convert them automatically en(encode_proto): When encoding values into string fields, attempt to convert them automatically Mar 3, 2025
@pront pront changed the title en(encode_proto): When encoding values into string fields, attempt to convert them automatically enhancement(encode_proto): When encoding values into string fields, attempt to convert them automatically Mar 3, 2025
pront
pront approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @roykim98. This makes sense 👍

@pront pront added the meta: awaiting author Pull requests that are awaiting their author. label Mar 3, 2025
@pront pront removed the meta: awaiting author Pull requests that are awaiting their author. label Mar 3, 2025
@pront pront enabled auto-merge March 3, 2025 20:16
@pront pront added this pull request to the merge queue Mar 3, 2025
Merged via the queue into vectordotdev:main with commit 6b6e874 Mar 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pront pront pront approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roykim98 @pront