Add an "advanced" LoggerFormatter API to expose more request metadata #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As LoggerHandlerImpl already calculated this important information, that is otherwise hard/impossible to get (e.g. request start time), so if we want to use that metadata in a formatter (e.g. to mimic LoggerFormat.DEFAULT) - it'd be best if we don't need to repeat work that had already been done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As LoggerHandlerImpl already calculated this important information, that is otherwise hard/impossible to get (e.g. request start time), so if we want to use that metadata in a formatter (e.g. to mimic LoggerFormat.DEFAULT) - it'd be best if we don't need to repeat work that had already been done.
I'm not happy with the new class's name - I'm just drawing a complete blank on what would be a good name. Suggestions are welcome 😅 .
Motivation:
Implement the feature request in issue #2367