Skip to content

Allow setting loglevel when creating a cron; include it in cron responses.#4789

Open
drakkhen wants to merge 8 commits intomasterfrom
drakkhen/op-3712/add-loglevel-to-cron-ui
Open

Allow setting loglevel when creating a cron; include it in cron responses.#4789
drakkhen wants to merge 8 commits intomasterfrom
drakkhen/op-3712/add-loglevel-to-cron-ui

Conversation

@drakkhen
Copy link

No description provided.

@drakkhen drakkhen marked this pull request as ready for review March 12, 2026 14:38

query = await tostr(query)

loglevel = kwargs.get('loglevel')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an opportunity to unify into something like reqValidLogLevel() somewhere central (maybe schemas.py?) to ensure consistency of the exception message/content 👍

@vEpiphyte
Copy link
Contributor

Is setting the log level to INFO or DEBUG something that is supposed to have a change in behavior for how the cron job is actually executed?

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.72%. Comparing base (9b3b1da) to head (5eac1ea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4789   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files         298      298           
  Lines       62504    62509    +5     
=======================================
+ Hits        61084    61089    +5     
  Misses       1420     1420           
Flag Coverage Δ
linux 97.65% <100.00%> (-0.01%) ⬇️
linux_replay 93.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@invisig0th
Copy link
Contributor

Is setting the log level to INFO or DEBUG something that is supposed to have a change in behavior for how the cron job is actually executed?

Haha, good point! I think we plumbed the option but didn't implement the feature?

@vEpiphyte
Copy link
Contributor

vEpiphyte commented Mar 18, 2026

Per discussion, we're leaving the existing _runjob behavior as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants