Allow setting loglevel when creating a cron; include it in cron responses.#4789
Allow setting loglevel when creating a cron; include it in cron responses.#4789
loglevel when creating a cron; include it in cron responses.#4789Conversation
synapse/lib/stormtypes.py
Outdated
|
|
||
| query = await tostr(query) | ||
|
|
||
| loglevel = kwargs.get('loglevel') |
There was a problem hiding this comment.
Seems like an opportunity to unify into something like reqValidLogLevel() somewhere central (maybe schemas.py?) to ensure consistency of the exception message/content 👍
|
Is setting the log level to |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4789 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 298 298
Lines 62504 62509 +5
=======================================
+ Hits 61084 61089 +5
Misses 1420 1420
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Haha, good point! I think we plumbed the option but didn't implement the feature? |
|
Per discussion, we're leaving the existing |
No description provided.