Skip to content

Add snphost CI PR test#91

Open
LakshmiSaiHarika wants to merge 2 commits intovirtee:mainfrom
LakshmiSaiHarika:main
Open

Add snphost CI PR test#91
LakshmiSaiHarika wants to merge 2 commits intovirtee:mainfrom
LakshmiSaiHarika:main

Conversation

@LakshmiSaiHarika
Copy link
Copy Markdown

Performs snphost cargo tests on the self-hosted runner

@larrydewey
Copy link
Copy Markdown
Contributor

Looks like you have a linting error @LakshmiSaiHarika

@LakshmiSaiHarika LakshmiSaiHarika force-pushed the main branch 2 times, most recently from 198fe39 to 9dd8737 Compare November 14, 2024 19:50
@LakshmiSaiHarika
Copy link
Copy Markdown
Author

Hi Reviewers, I edited this PR to add manual PR event and did some code cleanup.

Please review this and let me know if any additional changes are required.

Comment thread .github/workflows/snphost_ci_test.yml Outdated
runs-on: self-hosted
steps:
- name: Checkout Repository
uses: actions/checkout@v2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses: actions/checkout@v3


- name: Run snphost cargo test on the host
run: |
# Check and install dependencies on the host
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -e # exit immediately on error and fail fast

Comment thread .github/workflows/snphost_ci_test.yml Outdated

# Cleanup steps on the host
rm -rf ~/snphost
cd ~/
Copy link
Copy Markdown
Contributor

@AdithyaKrishnan AdithyaKrishnan Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir -p ~/snphost
cd ~

Comment thread .github/workflows/snphost_ci_test.yml Outdated

if [ ${{ github.event_name }} == "pull_request_target" ]; then
event_pr_number=${{ github.event.pull_request.number }}
event_pr_branch=${{ github.head_ref }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.head_ref -> github.event.pull_request.head.ref

@LakshmiSaiHarika LakshmiSaiHarika force-pushed the main branch 3 times, most recently from e62617b to 25632fc Compare November 20, 2024 03:57
Contains all the required function definitions for its use in snphost CI PR workflow.

Signed-off-by: Harika Nittala <lnittala@amd.com>
Added snphost CI PR test workflow to perform snphost cargo tests on the self-hosted runner for a new PR, updated PR or after SNP kernel update on the self-hosted runner

Signed-off-by: Harika Nittala <lnittala@amd.com>
@LakshmiSaiHarika
Copy link
Copy Markdown
Author

LakshmiSaiHarika commented Nov 21, 2024

I addressed the above comments.... Please let me know if any changes are required

Copy link
Copy Markdown
Contributor

@AdithyaKrishnan AdithyaKrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @LakshmiSaiHarika

@tylerfanelli
Copy link
Copy Markdown
Member

Is this still being worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants