Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
approved these changes
Jun 7, 2024
Collaborator
There was a problem hiding this comment.
Nice :)
A few thoughts:
- I initially expected to be able to interact with charts when zooming out, especially that there is a blue outline when hovering over them,
- also at first I thought that the whole canvas area extends, so I could have more charts on the sides 😅 would it make sense to add canvas outline when zooming out, so it's more clear that the canvas area stays "fixed"?
- also a thought it we actually need 0.25x and 0.5x; maybe it also would make sense to have an "overview" button that would always show all charts and dynamically adjust the scale?
This is just to write things down, the implementation looks good 💯
Collaborator
Author
|
Sorry should have been a draft PR. It was mostly to get feedback and allow @KerstinFaye to see it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short exploration to see if a zoom feature would be possible/useful
for dashboards.