Fix Naxxramas slime damage using WMO ID instead of filename parsing#3118
Open
kwsantiago wants to merge 2 commits intovmangos:developmentfrom
Open
Fix Naxxramas slime damage using WMO ID instead of filename parsing#3118kwsantiago wants to merge 2 commits intovmangos:developmentfrom
kwsantiago wants to merge 2 commits intovmangos:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Fix Naxxramas slime damage by using WMO ID instead of filename parsing. This replaces the fragile string-based detection with a proper ID check and removes the commented-out hackfix that was preventing all slime environmental damage.
Proof
rootWMO->member accesses in the codebaseIssues
How2Test
Test Naxxramas slime damage:
Test regular slime damage:
Verify the WMO fix:
Todo / Checklist
filename.find("Stratholme_raid")withrootWMO->RootWMOID == 4489check