Check itr in DeleteCharacterPetById#3222
Open
Wall-core wants to merge 1 commit intovmangos:developmentfrom
Open
Check itr in DeleteCharacterPetById#3222Wall-core wants to merge 1 commit intovmangos:developmentfrom
Wall-core wants to merge 1 commit intovmangos:developmentfrom
Conversation
It should never be invalid, but ensure it is so we don't crash.
Contributor
|
i have a slight issue with this type of fix. A crash would indicate that there is a bug somewhere else in the code - and this just masks the real issue. |
Contributor
Author
|
Yeah it should never be invalid at this part in the code, but if the two maps somehow desynced, it would crash if this were ever called. It's just more proper to actually check both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should never be invalid, but ensure it is so we don't crash.