update community-membership.md#134
Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the 'Owner' role from the community membership documentation and updates the 'Maintainer' requirements to focus on technical leadership and a super-majority voting process. It also adds a provision for adopter contact persons to become members. Feedback identifies an inconsistency in the summary table where 'owners' are still listed as sponsors for maintainers despite the role's removal, and suggests a minor phrasing and formatting improvement for the maintainer nomination requirement.
| | [Reivewer](#reviewer) | Sponsor from 2 maintainers, has basic experience and knowledge of domain, actively contributed to code and review | Review contributions from community members | Write access to specific packages in relevant repository | | ||
| | [Approver](#approver) | Sponsor from 2 maintainers, has good experience and knowledge of domain, actively contributed to code and review | Review and approve contributions from community members | Write access to specific packages in relevant repository | | ||
| | [Maintainer](#maintainer) | Sponsor from 2 owners, shown good technical judgement in feature design/development and PR review | Participate in release planning and feature development/maintenance | Top level write access to relevant repository. Name entry in Maintainers file of the repository | | ||
| | [Owner](#owner) | Sponsor from 3 owners, helps drive the overall Volcano project | Drive the overall technical roadmap of the project and set priorities of activities in release planning | Volcano GitHub organization Admin access | |
There was a problem hiding this comment.
The removal of the Owner role creates an inconsistency in the summary table on line 13. The Maintainer entry still lists 'Sponsor from 2 owners' as a requirement. This should be updated to align with the new nomination and voting process described in the Maintainer section.
| - Authoring and reviewing proposals | ||
| - Initiating, contributing and resolving discussions (e.g. emails, GitHub issues, meetings) | ||
| - Identifying subtle or complex issues in designs and implementation PRs | ||
| - Nominated by a maintainer and pass super-majority(two-thirds/ 66.66%) vote. |
There was a problem hiding this comment.
There is a missing space before the parenthesis, and the phrasing 'pass super-majority' is slightly awkward. Adding spaces around the slash also improves readability.
| - Nominated by a maintainer and pass super-majority(two-thirds/ 66.66%) vote. | |
| - Nominated by a maintainer and passing a super-majority (two-thirds / 66.66%) vote. |
2 participants
1、Delete
Ownermembership.2、Update Maintainer requirement.