Refactor/move docusaurus root#493
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the Volcano website from Hugo to Docusaurus, replacing Hugo-specific configuration and content with Docusaurus-compatible files. The review feedback highlights several formatting and syntax issues in the migrated markdown files, such as trailing backticks in code blocks, incorrect shell variable expansion syntax, and broken YAML values. It also identifies artifacts from conversion tools in URLs and text placeholders, along with typos and broken links that need correction.
|
What's the relationship between this pr and #490? |
|
Adding label DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@labdhiongithub7 So we only need to review this PR? |
| 本节提供指导帮助您快速上手 Volcano,从部署基本的 Volcano Job/Deployment,到集成 Volcano 队列。 | ||
|
|
||
| ## 前置条件 | ||
| 已成功安装带有 Volcano 组件的 Kubernetes 集群。如果您尚未安装 Volcano,请参阅 [安装指南](/docs/GettingStarted/Installation)。 |
There was a problem hiding this comment.
Did you change the translation for Chinese? @labdhiongithub7 https://volcano.sh/zh/docs/tutorials/, why not just migrate the existing doc to the new dir?
JesseStutler
left a comment
There was a problem hiding this comment.
I'm curious that why CN docs have to put under i18n/zh-Hans? They can put together in docs dir with those English docs? Becasue Hugo seperate En and CN docs through different dirs but still same under dos large dir
There was a problem hiding this comment.
Does not finish the README yet?
And I remember that we should add a user guide to let new contributors know how we organize the stucture of our website( write the layout is better), and teach if a new contributor wants to add a new doc, where he/she should add, add how to render the website in their local env
There was a problem hiding this comment.
Yes sir I'm currently working on it
yes @JesseStutler |
Docusaurus handles i18n differently from Hugo. In Hugo, EN and CN docs can stay under the same large content structure because each language is treated as a separate content tree. In Docusaurus, English docs under |
Thanks for catching that. You're right there are some minor wording differences. I'll update the file to match the existing translation from the live site exactly |
|
Thanks for your great work! I think it's approaching to get merged. Could you resolve the conflicts and push again? @labdhiongithub7 |
|
|
||
| We use [Docusaurus](https://docusaurus.io/) to format and generate our website, and [Netlify](https://www.netlify.com/) to manage the deployment of the site. Docusaurus is an open-source static site generator that provides us with templates, content organisation in a standard directory structure, and a website generation engine. You write the pages in Markdown (with YAML front matter), and Docusaurus wraps them up into a website. | ||
|
|
||
| Please see [How to contribute](https://github.com/volcano-sh/website/blob/master/CODE_OF_CONDUCT.md) for instructions on how to contribute, if you are not familiar with the GitHub workflow. |
There was a problem hiding this comment.
Why is how to contribute linked to the Code of conduct? @labdhiongithub7 Please check , if you're using AI agent to help finish to docs, you should verify and make sure all the thing are correct. AI may have illusion
There was a problem hiding this comment.
Sorry @JesseStutler for the oversight, I'll be more careful . I'll update it
|
|
||
| Please see [How to contribute](https://github.com/volcano-sh/website/blob/master/CODE_OF_CONDUCT.md) for instructions on how to contribute, if you are not familiar with the GitHub workflow. | ||
|
|
||
| ## Quickstart |
There was a problem hiding this comment.
I think the old README docs is also not correct, this section is not a quickstart guide, quick start should teach users how to add new docs/update docs and run in the local, this section may be more like a preview section and should be put at last, not at the beginning I think
There was a problem hiding this comment.
This was carried over from the old README. I'll restructure it under preview section and update the quick start guide
There was a problem hiding this comment.
Also please add a section to teach that how to archive a version of docs when a new version get released @labdhiongithub7
There was a problem hiding this comment.
Got it! The Docusaurus docs already cover this pretty well (https://docusaurus.io/docs/versioning), so I'll add a short section in the README summarizing it and link back to the official docs for more details.
|
Hi @labdhiongithub7 I want to learn that where do you mark the current version as the latest? |
| ├── versioned_sidebars/ # Sidebar snapshots for past releases | ||
| │ | ||
| ├── i18n/zh-Hans/ # Chinese (Simplified) translations | ||
| │ ├── docusaurus-plugin-content-docs/ |
There was a problem hiding this comment.
I'm curious that why Chinese dir name seems so long, you can see for the english doc, it's just docs/
i18n/zh-Hans/docs/<section> and i18n/zh-Hans/blog/ also? It will more clear for meThere was a problem hiding this comment.
Actually it's a convention by Docusaurus here is the reference:
https://docusaurus.io/docs/i18n/introduction#translation-files-location
There was a problem hiding this comment.
I got it, thanks, here is another repo that can be refered: https://github.com/koordinator-sh/website/blob/main/README.md, and we need to clarify that how Chinese docs be organized
The current version is marked as latest in docusaurus.config.js, for English and In i18n/zh-Hans/docusaurus-plugin-content-docs/current.json for Chinese |
de6p
left a comment
There was a problem hiding this comment.
public/ folder should be merged into static/ folder where needed, then removed to avoid confusion.
|
|
||
| [context.next.environment] | ||
| HUGO_ENABLEGITINFO = "true" | ||
| [[redirects]] |
There was a problem hiding this comment.
The /* → /index.html rule in netlify.toml is an SPA fallback pattern. Docusaurus already outputs static HTML per route (build/docs/.../index.html, etc.), so this rule isn’t needed and can hide real 404s by serving the homepage with a 200 for missing paths.
| sidebarPath: require.resolve('./sidebar.js'), | ||
| showLastUpdateTime: true, | ||
| showLastUpdateAuthor: false, | ||
| editUrl: "https://github.com/volcano-sh/website/tree/main/", |
There was a problem hiding this comment.
editUrl points to main, default branch is master
|
|
||
| ### Prepare | ||
|
|
||
| Install [prometheus](https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus) or [prometheus-adaptor](https://github.com/prometheus-community/helm- c harts/tree/main/charts/prometheus-adapter), and [prometheus-node-exporter](https://github.com/prometheus-community/helm-charts/tree/main/charts/prometheus-node-exporter), The real load of the node is exposed to the `Volcano descheduler` through node-exporter and prometheus. |
There was a problem hiding this comment.
Space in helm- c harts breaks the link (also in v1.11/v1.12 versioned copies).
| --- | ||
| This section provides guidance to help you quickly get started with Volcano, from deploying a basic Volcano Job/Deployment, to integrating with Volcano Queues | ||
| ## Prerequisites | ||
| A Kubernetes cluster with Volcano components need to be installed successfully. If you haven't installed Volcano yet, please refer to [Installation](https://volcano.sh/en/docs/installation/). |
There was a problem hiding this comment.
Old website link, When someone clicks that link on the new site, they go to a URL that may not exist anymore → 404 or wrong page.
de6p
left a comment
There was a problem hiding this comment.
Docs still link to Hugo URLs and Hugo file paths; they need to link to Docusaurus URLs and the current docs/ file paths instead.
There alot of files, so please fix this .
docs/GettingStarted/Tutorials.md, docs/Contribution/VolcanoContribution.md, docs/UserGuide/user_guide_how_to_configure_scheduler.md, all matching versioned_docs/**/Tutorials.md and VolcanoContribution.md, i18n/zh-Hans/.../GettingStarted/Tutorials.md, .../how-to-configure-scheduler.md, and i18n/zh-Hans/.../blog/Volcano-1.10.0|1.11.0|1.13.0-release.md.
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <labdhigandhinew077@gmail.com> Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <labdhigandhinew077@gmail.com> Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <labdhigandhinew077@gmail.com> Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
da3ee61 to
f67b2de
Compare
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
…Guide - Move user guide docs from versioned_docs/v1.12.0/Ecosystem to docs/UserGuide - Replace old kebab-case filenames with snake_case user_guide_*.md - Fix extender: escape curly braces to prevent MDX JSX parsing error - Fix numa-aware: use self-closing <br/> tags for MDX compatibility - Fix vnpu: correct broken relative link to volcano_vgpu doc - Fix capacity: replace broken relative design doc link with GitHub URL Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
…fixes Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
f67b2de to
dd0ea14
Compare
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
Signed-off-by: labdhiongit7 <img_2022034@iiitm.ac.in>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: de6p, JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |


What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
/kind feature
What this PR does / why we need it:
This PR introduces an migration of the Volcano website from Hugo to Docusaurus.
Which issue(s) this PR fixes:
N/A