docs: add volcano plugin guides#499
Conversation
Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>
…s, priority, sla, tdm) Signed-off-by: hemantch01 <hemantchaudhary905@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive set of user guides for various Volcano scheduler plugins, including Binpack, DRF, Gang, NodeOrder, Predicates, Priority, Proportion, SLA, and TDM. The review feedback identifies configuration errors in the Gang plugin documentation regarding argument nesting and naming, and highlights the missing 'preempt' action in the TDM plugin's scheduler configuration example.
| - name: gang | ||
| enablePreemptable: false |
There was a problem hiding this comment.
The configuration for the gang plugin is missing the arguments key. In Volcano, plugin-specific configurations must be nested under arguments. Additionally, the standard argument name for controlling preemption in the gang plugin is gang.preemptable rather than enablePreemptable.
| - name: gang | |
| enablePreemptable: false | |
| - name: gang | |
| arguments: | |
| gang.preemptable: false |
| namespace: volcano-system | ||
| data: | ||
| volcano-scheduler.conf: | | ||
| actions: "enqueue, allocate, backfill" |
There was a problem hiding this comment.
The preempt action is missing from the actions list. The TDM plugin relies on the preempt action to trigger the eviction of workloads when the time window expires, as described in the Verification section.
| actions: "enqueue, allocate, backfill" | |
| actions: "enqueue, allocate, preempt, backfill" |
|
Thanks for your great work, but I prefer not to put plugins related docs under user guide, but to set the plugin as the second menu and then put all plugin related docs into it. We can first wait until #493 merged and then continue refactoring |
What kind of change does this PR introduce? /kind documentation
What this PR does / why we need it:
This PR finalizes and adds the missing user guides for the core Volcano scheduling plugins (
Binpack,NodeOrder,Predicates,Priority,SLA, andTDM). All guides follow the standard maintainer frontmatter and structure, and have been locally verified on a Minikube cluster.Which issue(s) this PR fixes:
Fixes [Docs] Missing User Guides for core scheduling plugins (Binpack, NodeOrder, Priority, etc.) #498