Skip to content

Add favicon to Volcano website #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volcano-sh-bot merged 1 commit into from
Jun 2, 2026
+29 −2
Merged

Add favicon to Volcano website #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions docusaurus.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,33 @@ const config = {
url: "https://volcano.sh",
baseUrl: "/",

favicon: "img/favicons/favicon.ico",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR description states that this change "copies favicon.ico to the site root for clients that request /favicon.ico". However, there is no static/favicon.ico file included in this pull request, nor are there any build scripts or plugins configured to perform this copy.

To make the favicon available at the root /favicon.ico (which many browsers and crawlers query by default), please physically copy the favicon.ico file to static/favicon.ico and commit it as part of this PR.

Copy link
Copy Markdown
Contributor Author

@kubeboiii kubeboiii May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static/favicon.ico is already in this PR (see Files changed, commit 7f89bb7). It is a direct copy of static/img/favicons/favicon.ico and is served at /favicon.ico via Docusaurus static assets. No build step needed.


headTags: [
{
tagName: "link",
attributes: {
rel: "apple-touch-icon",
href: "/img/favicons/apple-touch-icon.png",
},
},
{
tagName: "link",
attributes: {
rel: "manifest",
href: "/img/favicons/site.webmanifest",
},
},
{
tagName: "link",
attributes: {
rel: "mask-icon",
href: "/img/favicons/safari-pinned-tab.svg",
color: "#eb341a",
},
},
],

organizationName: "volcano-sh",
projectName: "website",

Expand Down
Binary file added static/favicon.ico
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions static/img/favicons/site.webmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "",
"short_name": "",
"name": "Volcano",
"short_name": "Volcano",
"icons": [
{
"src": "/img/favicons/android-chrome-192x192.png",
Expand Down