Skip to content

fix(theme): improve dark mode visibility for icons and logos #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hemantch01 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(theme): improve dark mode visibility for icons and logos #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,12 @@ b, strong {
margin-left: 8px;
background-position: center;
background-repeat: no-repeat;
background-size: 20px;
transition: opacity .2s ease;
}

.header-github-link { background-image: url("/img/github.svg"); }
.header-x-link { background-image: url("/img/x.svg"); }
.header-slack-link { background-image: url("/img/slack.svg"); }
.header-github-link { background-image: url("/img/github.svg"); background-size: 23px; }
.header-x-link { background-image: url("/img/x.svg"); background-size: 18px; }
.header-slack-link { background-image: url("/img/slack.svg"); background-size: 22px; }

.header-github-link:hover,
.header-x-link:hover,
Expand Down Expand Up @@ -129,3 +128,14 @@ b, strong {
.theme-edit-this-page {
display: none !important;
}


[data-theme="dark"] .header-github-link,
[data-theme="dark"] .header-x-link {
filter: invert(1) brightness(100%);
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The brightness(100%) filter is redundant because 100% is the default brightness value. You can simplify this filter to just invert(1).

Suggested change
filter: invert(1) brightness(100%);
filter: invert(1);

}

[data-theme="dark"] .navbar__logo {

filter: invert(1) hue-rotate(180deg) brightness(1.1);
}
Comment on lines +138 to +141
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using CSS filters like invert() and hue-rotate() to style the dark mode logo is a sub-optimal practice that can lead to color distortion, rendering artifacts, and poor performance. Docusaurus provides native support for dark mode logos via the srcDark property in docusaurus.config.js. It is highly recommended to use a dedicated dark-themed logo asset instead of applying CSS filters. To implement this, add the srcDark property to the logo configuration in docusaurus.config.js (e.g., srcDark: "img/landing/volcano_logo_dark.png") and remove this CSS filter block entirely.