Skip to content

fix(cli): tolerate BOM in ov config#1922

Merged
qin-ctx merged 1 commit intovolcengine:mainfrom
duyua9:fix/config-bom-duyua9
May 9, 2026
Merged

fix(cli): tolerate BOM in ov config#1922
qin-ctx merged 1 commit intovolcengine:mainfrom
duyua9:fix/config-bom-duyua9

Conversation

@duyua9
Copy link
Copy Markdown
Contributor

@duyua9 duyua9 commented May 8, 2026

Summary

  • read ov.conf with utf-8-sig in openviking-server doctor
  • read ov.conf with utf-8-sig in OpenVikingConfigSingleton._load_from_file
  • add focused coverage for BOM-prefixed config files

Validation

  • uvx ruff check openviking_cli/doctor.py openviking_cli/utils/config/open_viking_config.py tests/cli/test_doctor.py tests/test_config_loader.py
  • uvx ruff format --check openviking_cli/doctor.py openviking_cli/utils/config/open_viking_config.py tests/cli/test_doctor.py tests/test_config_loader.py
  • python3 -m py_compile openviking_cli/doctor.py openviking_cli/utils/config/open_viking_config.py tests/cli/test_doctor.py tests/test_config_loader.py
  • ad-hoc BOM smoke for check_config() and OpenVikingConfigSingleton.initialize(config_path=...)
  • git diff --check

Note: direct pytest collection in this local checkout is blocked by a missing optional test dependency (pathspec) imported from tests/conftest.py, so I used the focused import/behavior smoke above for the new paths.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 95
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx merged commit ba54e38 into volcengine:main May 9, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants