Skip to content

Revert Qdrant vectordb support#2388

Closed
qin-ctx wants to merge 1 commit into
mainfrom
revert/qdrant-vectordb
Closed

Revert Qdrant vectordb support#2388
qin-ctx wants to merge 1 commit into
mainfrom
revert/qdrant-vectordb

Conversation

@qin-ctx
Copy link
Copy Markdown
Collaborator

@qin-ctx qin-ctx commented Jun 2, 2026

Description

Revert PR #2350 because the Qdrant backend is not ready to support required directory/path-scope behavior.

This rollback removes the Qdrant VectorDB backend implementation, adapter registration, Qdrant-specific tests, and follow-up Qdrant references that would otherwise import deleted adapter code.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Reverted add Qdrant vectordb support (#2350).
  • Removed Qdrant adapter implementation, REST/meta-store collection code, registration, and Qdrant tests.
  • Removed Qdrant references from adapter exports and the English/Chinese VectorDB configuration docs.

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Tested locally on macOS with:

  • ruff and ruff format via pre-commit hooks
  • .venv/bin/python -c 'from openviking.storage import vectordb_adapters; from openviking_cli.utils.config.vectordb_config import VectorDBBackendConfig; ...'
  • .venv/bin/python -m pytest tests/storage/test_opengauss_adapter.py tests/storage/test_vectordb_adaptor.py tests/misc/test_config_validation.py

Result: 41 passed, 1 skipped.

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

N/A

Additional Notes

This PR also removes Qdrant references added by follow-up docs/export changes after #2350, because keeping them would leave broken imports after the adapter files are deleted.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

2350 - Partially compliant

Compliant requirements:

(This PR reverts the above requirements)

Non-compliant requirements:

  • Add Qdrant as a VectorDB backend
  • Include REST-based Qdrant collection implementation
  • Add adapter registration and backend configuration
  • Add sidecar metadata handling
  • Add tests for Qdrant-specific behavior

Requires further human verification:

  • Verify that all Qdrant references are removed
  • Verify that existing functionality works as expected
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx qin-ctx closed this Jun 2, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project Jun 2, 2026
@qin-ctx qin-ctx deleted the revert/qdrant-vectordb branch June 5, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant