Skip to content

docs(resources): note local directory uploads skip symlink entries (#2374)#2394

Closed
r266-tech wants to merge 1 commit into
volcengine:mainfrom
r266-tech:docs-resources-symlink-skip-2374
Closed

docs(resources): note local directory uploads skip symlink entries (#2374)#2394
r266-tech wants to merge 1 commit into
volcengine:mainfrom
r266-tech:docs-resources-symlink-skip-2374

Conversation

@r266-tech
Copy link
Copy Markdown
Contributor

#2374 (skip symlinks in directory uploads) changed what add_resource / add_skill ingest from a local directory, but the Additional Notes ingestion-contract list in docs/{en,zh}/api/02-resources.md only documents the .gitignore / ignore_dirs / include / exclude filters — not the new symlink skipping.

Adds one parallel EN+ZH bullet: symlink entries (file & directory) are skipped, real files are still ingested via their actual path, and an all-symlink directory yields an empty (warned) archive — grounded in openviking_cli/client/http.py _zip_directory.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

2374 - Partially compliant

Compliant requirements:

  • Update documentation to note symlink skipping behavior (both English and Chinese)

Non-compliant requirements:

  • Skip symlinks in directory uploads (code change)
  • Keep archives bounded to real files (code change)
  • Warn on empty archive (code change)
  • Add regression coverage (tests)
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 100
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@qin-ctx
Copy link
Copy Markdown
Collaborator

qin-ctx commented Jun 3, 2026

not important

@qin-ctx qin-ctx closed this Jun 3, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in OpenViking project Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants