Fix proxy authentication by upgrading attohttpc to 0.29.1 #2091
+244
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volta previously failed to download Node.js through authenticated proxies, returning "401 Unauthorized" errors. The issue was that attohttpc 0.28 doesn't extract credentials from proxy URLs or send Proxy-Authorization headers during CONNECT handshakes. Version 0.29.1 adds proxy authentication support (attohttpc PR volta-cli#185), properly handling credentials in proxy URLs like http://user:pass@proxy:port. Pinned to exactly 0.29.1 because versions 0.29.2+ contain lifetime errors that don't compile with Rust 1.75 (the project's toolchain version). Fixes volta-cli#2090 Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Author
|
I just saw that Vite is not being maintained anymore so I don't have high expectations here. Also turns out that we probably won't need it for our own project much longer either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background
Volta was unable to download Node.js in environments using authenticated HTTP proxies (e.g., Claude Code remote sessions, corporate networks). The underlying HTTP library (attohttpc 0.28) didn't extract credentials from proxy URLs (format:
http://user:pass@proxy:port) or send theProxy-Authorizationheader during CONNECT handshakes.Version 0.29.1 adds this support via attohttpc PR #185.
Changes
crates/volta-core/Cargo.toml- Upgraded attohttpc to =0.29.1 with explanatory commentscrates/archive/Cargo.toml- Upgraded attohttpc to =0.29.1 with explanatory commentsCargo.lock- Updated dependencies (includes transitive deps from rustls changes)Test Plan
Fixes #2090
🤖 Generated with Claude Code