Skip to content

Conversation

@demiankatz
Copy link
Member

@demiankatz demiankatz commented Dec 3, 2025

The Favorites controller plugin was deprecated in release 10.0, has not been used since then, and can be safely removed as part of the controller plugin cleanup in release 12.0.

TODO

  • Update changelog when merging.

@demiankatz demiankatz added this to the 12.0 milestone Dec 3, 2025
@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label Dec 3, 2025
Copy link
Contributor

@ThoWagen ThoWagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'favorites' => 'VuFind\Controller\Plugin\Favorites',

in the aliases in module/VuFind/config/module.config.php can also be removed.

@demiankatz demiankatz requested a review from ThoWagen December 9, 2025 10:34
@demiankatz
Copy link
Member Author

Good catch, @ThoWagen -- all fixed now!

@demiankatz demiankatz merged commit b01c385 into vufind-org:dev-12.0 Dec 9, 2025
4 checks passed
@demiankatz demiankatz deleted the drop-favorites-plugin branch December 9, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

architecture pull requests that involve significant refactoring / architectural changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants