Fix broken SolrJ symlinks in import script. #4934
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been reported that using .deb packages to upgrade VuFind leaves behind outdated .solrj symlinks which break import following the upgrade (since SolrMarc can't find SolrJ). I imagine that there may be other scenarios that could leave these unwanted links behind after a Solr update. This PR adds logic to validate the symlinks and fix them as needed.
I did not take the time to add equivalent logic to the Windows batch file; since I'm not aware of a Windows scenario that would cause this situation, it seemed better not to overcomplicate things.
An alternate solution might be to update the .deb package script to wipe out any existing .solrj symlinks as part of the installation. That would have the advantage of not adding more processing to every import call, but the disadvantage of being a less general solution.
Feedback welcome!