Add extra context to template rendering #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jams2
reviewed
Aug 12, 2025
wagtail_newsletter/models.py
Outdated
| def get_newsletter_html(self, extra_context=None) -> SafeString: | ||
| context = self.get_newsletter_context() | ||
| if extra_context: | ||
| context = copy(context) |
There was a problem hiding this comment.
Question: why copy the context dict? It seems like an unnecessary step given that it isn't reused. If observing immutability of the dict is important for some reason, you could use the dict union operator and skip the import.
Member
Author
There was a problem hiding this comment.
Just a bit of paranoia in case people do something silly.
I thought being explicit was better, but now I like the ** approach better. Changed in 0747582. Thanks!
jams2
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80.