Import ImproperlyConfigured
#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot to import this when adding it in my previous PR.
chigby
force-pushed
the
fix-unimported-name
branch
from
627a8b9 to
c3be425
Compare
Running the pre-commit script generated these changes.
The error: ``` Error: Argument of type "dict[str, int]" cannot be assigned to parameter "value" of type "str" in function "__setitem__" "dict[str, int]" is not assignable to "str" (reportArgumentType) ```
chigby
force-pushed
the
fix-unimported-name
branch
from
4ce76c7 to
bfd1168
Compare
Contributor
Author
|
All checks passing! I had to make a few other slight modifications (both non-functional changes) to convince pre-commit and pyright to give me the "ok!" but that seems like it's happening. @mgax this should be ready to merge if you approve. |
mgax
approved these changes
Nov 18, 2025
Member
mgax
left a comment
mgax
left a comment
There was a problem hiding this comment.
Oh yes, dict typing can be fun 🫠
Thank you for taking the time to make the CI happy! 🦸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to import this when adding it in my previous PR.