Skip to content

Conversation

@Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Oct 13, 2025

Description

Start having info log level as the default one.

Before, we were using debug as the default one and the next possible log level is trace, which is very intense, particularly, within nim-libp2p.

Therefore, with that, we will have some more freedom to actually add "debug" logs, that we don't want to always appear, but they are not the extremely spammy trace.

The original reason for that came after noticing that two waku relay protocol.nim logs were relatively intense, but I don't want to move them to trace. See the following log distribution from status.prod and v0.36.0:
image

btw - thanks @yakimant and @jakubgs to teach about the most consuming logs 🙌

Changes

  • Generic refactor to substitute debug "... with info "...
  • Move notice to debug in
    notice "received relay message",
    my_peer_id = w.switch.peerInfo.peerId,
    msg_hash = msg_hash,
    msg_id = msg_id_short,
    from_peer_id = remotePeerId,
    topic = topic,
    receivedTime = getNowInNanosecondTime(),
    payloadSizeBytes = msg.payload.len
    else:
    notice "sent relay message",

Issue

@github-actions
Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3622

Built from ec83f16

@Ivansete-status Ivansete-status marked this pull request as ready for review October 13, 2025 14:46
Copy link
Contributor

@fcecin fcecin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ivansete-status Ivansete-status changed the title Move debug to info log level Move log level from debug to info Oct 14, 2025
Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the cleanup.

Copy link
Contributor

@darshankabariya darshankabariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, LGTM

@Ivansete-status Ivansete-status merged commit 7e5041d into master Oct 15, 2025
15 of 16 checks passed
@Ivansete-status Ivansete-status deleted the mv-debug-to-info-log-level branch October 15, 2025 08:49
@Ivansete-status
Copy link
Collaborator Author

@darshankabariya - kindly include this change in v0.37.0 🥳
@jakubgs - as a reminder for the upcoming future :), after v0.37.x is deployed, we will need to change the log-level to INFO in infra

@darshankabariya
Copy link
Contributor

@darshankabariya - kindly include this change in v0.37.0 🥳 @jakubgs - as a reminder for the upcoming future :), after v0.37.x is deployed, we will need to change the log-level to INFO in infra

Thanks for notify will add in v0.37.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants