-
Notifications
You must be signed in to change notification settings - Fork 79
Move log level from debug to info #3622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from ec83f16 |
fcecin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jakubgs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the cleanup.
darshankabariya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, LGTM
|
@darshankabariya - kindly include this change in v0.37.0 🥳 |
Thanks for notify will add in v0.37.0 |
Description
Start having
infolog level as the default one.Before, we were using
debugas the default one and the next possible log level istrace, which is very intense, particularly, within nim-libp2p.Therefore, with that, we will have some more freedom to actually add "debug" logs, that we don't want to always appear, but they are not the extremely spammy
trace.The original reason for that came after noticing that two waku relay protocol.nim logs were relatively intense, but I don't want to move them to

trace. See the following log distribution from status.prod and v0.36.0:btw - thanks @yakimant and @jakubgs to teach about the most consuming logs 🙌
Changes
debug "...withinfo "...noticetodebuginnwaku/waku/waku_relay/protocol.nim
Lines 181 to 190 in 7b234ec
Issue