Skip to content

Conversation

@fryorcraken
Copy link
Collaborator

Description

Changes

Issue

closes #

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3623

Built from 9394463

@arnetheduck
Copy link
Contributor

arnetheduck commented Oct 19, 2025

See https://github.com/waku-org/nwaku/actions/runs/18629325159/job/53111753844 and the corresponding branch https://github.com/waku-org/nwaku/tree/simpler-deps - there are a few problems in this PR that I can tell:

  • the mix dependency is broken (there's no 0.1.0 tag/branch - probably, the version was intended)
  • the CI script installs one version of nwaku via nimble install nwaku@#someversion and then the package requests a conflicting version - this is messy
  • libp2p itself has some messy deps that are getting fixed - in the meantime, I put #wip-ngui3 since the same issues apply to nimbus

https://github.com/waku-org/nwaku/compare/waku-as-nimble-lib...simpler-deps?expand=1 shows the diff that gets CI to a point where the example is being compiled

@arnetheduck
Copy link
Contributor

cc @jazzz for the mix dep

@fryorcraken
Copy link
Collaborator Author

* the CI script installs one version of nwaku via `nimble install nwaku@#someversion` and then the package requests a _conflicting_ version - this is messy

Ah yes, I think this got messy as iterated and tried various strategies.

How would you recommend the cleanest way of doing this? remove requires waku in example.nimble file and just call nimble add waku@#someversion ?

@fryorcraken
Copy link
Collaborator Author

getting there... now fixing some compilations errors:

@fryorcraken
Copy link
Collaborator Author

we have a successful build: https://github.com/waku-org/nwaku/actions/runs/18641762303/job/53141969665?pr=3623
with commit: 5ae6b01 (#3623)

However, suprisingly the run command fails afterwards. (nimble 0.20.1)

@fryorcraken
Copy link
Collaborator Author

Same issue with nimble nightly. Some dependency conflict that is not picked up by nimble build. Will review if I can solve them.

@arnetheduck
Copy link
Contributor

nimble add waku@#someversion

this command is for adding a new requires line.

How would you recommend the cleanest way of doing this?

What's this exactly?

If this is just "check that the waku nimble file looks good", the easiest thing is to run nimble check -l or nimble deps -l in the top-level folder with the main waku nimble file (ie not on this example), possibly removing its bin setting (libraries that have bin set take longer to install) - this ensures that the nimble file isn't internally contradictory, ie that version resolution works for someone that will consume the "next" version when it gets released.

For day-to-day building and running, I tend to use nimble setup -l followed by nimble shell which works like a python venv, ie you get an isolated shell where all the paths are set up correctly. In that shell, nim c ... works as usual and has all the paths set up to point to the local environment.

@fryorcraken
Copy link
Collaborator Author

latest blocker locally: status-im/nim-dnsdisc#25

not sure what is happening with the CI as it works better locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants