-
Notifications
You must be signed in to change notification settings - Fork 76
feat: ensure waku is installable via nimble #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
You can find the image built from this PR at Built from 9394463 |
6739ec9 to
a292ace
Compare
|
See https://github.com/waku-org/nwaku/actions/runs/18629325159/job/53111753844 and the corresponding branch https://github.com/waku-org/nwaku/tree/simpler-deps - there are a few problems in this PR that I can tell:
https://github.com/waku-org/nwaku/compare/waku-as-nimble-lib...simpler-deps?expand=1 shows the diff that gets CI to a point where the example is being compiled |
|
cc @jazzz for the mix dep |
Ah yes, I think this got messy as iterated and tried various strategies. How would you recommend the cleanest way of doing this? remove |
6aedf7c to
8066b96
Compare
|
getting there... now fixing some compilations errors:
|
|
we have a successful build: https://github.com/waku-org/nwaku/actions/runs/18641762303/job/53141969665?pr=3623 However, suprisingly the |
|
Same issue with nimble nightly. Some dependency conflict that is not picked up by nimble build. Will review if I can solve them. |
this command is for adding a new
What's If For day-to-day building and running, I tend to use |
|
latest blocker locally: status-im/nim-dnsdisc#25 not sure what is happening with the CI as it works better locally. |
And avoid ambiguous call error for now
Not sure how the previous script ever worked when checking zerokit assets on GitHub
53baad4 to
ce19d16
Compare
Description
Changes
Issue
closes #