Skip to content

Conversation

@chaitanyaprem
Copy link
Contributor

@chaitanyaprem chaitanyaprem commented Nov 14, 2025

Description

As per discussions here and in general for better anonymity, we should switch to configuration where the mix exit node is same as destination peer. This way the protocol handler i.e lightpush handler will be invoked from mix layer directly in same node.

Ref Milestone waku-org/pm#365, but since changes are available in mix we may as well take this change now instead of waiting to implement js-mix.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3642

Built from 9297f30

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
Just added two nitpicks :D

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but is a design choice that has some impact on our assumptions (service nodes should support mix). Therefore I think the exit==destination choice should be described in the Waku-mix spec: https://github.com/waku-org/specs/blob/master/standards/core/mix.md

@chaitanyaprem
Copy link
Contributor Author

This LGTM but is a design choice that has some impact on our assumptions (service nodes should support mix). Therefore I think the exit==destination choice should be described in the Waku-mix spec: https://github.com/waku-org/specs/blob/master/standards/core/mix.md

We have already indicated that relay nodes should mount mix, isn't that enough or should we be more explicit that service-nodes should mount mix as well?

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from mix/rendezvous-updates to master November 21, 2025 17:45
@chaitanyaprem chaitanyaprem merged commit 088e310 into master Nov 22, 2025
11 of 12 checks passed
@chaitanyaprem chaitanyaprem deleted the mix/exit-dest branch November 22, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants