-
Notifications
You must be signed in to change notification settings - Fork 79
use exit==destination approach for mix for better anonymity #3642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can find the image built from this PR at Built from 9297f30 |
Ivansete-status
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for it! 💯
Just added two nitpicks :D
625efce to
b38b2ea
Compare
jm-clius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM but is a design choice that has some impact on our assumptions (service nodes should support mix). Therefore I think the exit==destination choice should be described in the Waku-mix spec: https://github.com/waku-org/specs/blob/master/standards/core/mix.md
We have already indicated that relay nodes should mount mix, isn't that enough or should we be more explicit that service-nodes should mount mix as well? |
NagyZoltanPeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4c8c37f to
4cc73a2
Compare
b38b2ea to
a459d3e
Compare
Description
As per discussions here and in general for better anonymity, we should switch to configuration where the mix exit node is same as destination peer. This way the protocol handler i.e lightpush handler will be invoked from mix layer directly in same node.
Ref Milestone waku-org/pm#365, but since changes are available in mix we may as well take this change now instead of waiting to implement js-mix.