Updated to enable persist of the snowball-arenas object. #4
Open
ekellener wants to merge 4 commits intowalterhiggins:masterfrom
Open
Updated to enable persist of the snowball-arenas object. #4ekellener wants to merge 4 commits intowalterhiggins:masterfrom
ekellener wants to merge 4 commits intowalterhiggins:masterfrom
Conversation
Current version of the game doesn't appear to persist to the filesystem correctly for snowball-arenas. The thinking was to only have a single object reference to the persist object() and expose it externally to the snowball command in Command.js
Current version of the game doesn't appear to persist to the filesystem correctly for snowball-arenas. The thinking was to only have a single object reference to the persist object() and expose it externally through getArenas().
updated plurality
Updated plurality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of the game doesn't appear to persist to the filesystem correctly for snowball-arenas (it doesn't write to the file when it's unloaded, or when js refresh() is issued). The thinking was to only have a single object reference to the persist object() through getArena() and expose it externally to the snowball command in Command.js It's entirely possible (and likely), there's a more elegant way to fix this. Would love to get your insight.