-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[issue-3474] SSL context SSL_VERIFY_POST_HANDSHAKE
#3479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[issue-3474] SSL context SSL_VERIFY_POST_HANDSHAKE
#3479
Conversation
Co-developed-by: Gemini 2.5 Pro
This commit contains fixes for two separate issues:
1. Deaddrop upload issues:
- The UI spinner would hang after a successful upload.
- The initial fix for this also addresses 302/404 redirects seen
on some platforms.
The root cause was incorrect HTTP response handling for the upload
POST request. This is fixed by simplifying the response handler to
send a standard, headers-only 200 OK response, and by ensuring
the request doesn't fall through to the dummy http handler.
2. Windows spawn build errors:
- The file `lib/plat/windows/windows-spawn.c` failed to build due
to undeclared identifiers and incomplete struct definitions.
This is fixed by including the necessary `Psapi.h` header and by
adding the missing `ft_create` and `ft_exit` members to the
`lws_spawn_piped` struct definition for WIN32 builds.
# Conflicts: # .sai.json # lib/core/libwebsockets.c # lib/plat/windows/windows-spawn.c # minimal-examples-lowlevel/http-client/minimal-http-client-multi/CMakeLists.txt # minimal-examples-lowlevel/http-client/minimal-http-client-post/CMakeLists.txt
…HANDSHAKE` handling within `SSL_set_SSL_CTX()`
|
You can't really merge main cleanly, you should use rebasing to work with that branch. It's just an accident if any new main would apply cleanly on top of any old main, patches may get pushed in place several times as they are developed. You should be able to merge the stable branches, just not main. You can read more about it here https://github.com/warmcat/libwebsockets/blob/main/READMEs/README.release-policy.md For this I just cherry-picked your change from your branch. |
Got it, thank you. I'll switch from merge to rebase |
a677221 to
0c67054
Compare
f5fa440 to
278c671
Compare
In
/lib/tls/mbedtls/wrapper/platform/ssl_pm.caddSSL_VERIFY_POST_HANDSHAKEhandling withinSSL_set_SSL_CTX()