Open
Conversation
Collaborator
|
This is super neat! Looking forward to giving this a review 👀 |
…into template_processor
…into template_processor
gregfurman
requested changes
Apr 12, 2026
Collaborator
gregfurman
left a comment
gregfurman
left a comment
There was a problem hiding this comment.
Apologies for the delay in review here. Once the conflicts are resolved, and my small comments addresses, this LGTM!
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if name == "meta" { |
Collaborator
There was a problem hiding this comment.
Should we not be doing the same for all functions/operators to ensure we don't override defaults? https://pkg.go.dev/text/template#hdr-Functions
| func TemplateProcessorSpec() *service.ConfigSpec { | ||
| return service.NewConfigSpec(). | ||
| Categories("Mapping"). | ||
| Beta(). |
Collaborator
There was a problem hiding this comment.
IMO let's comment this out for now and allow this component to be marked as experimental -- will require a make docs run 🙂
Suggested change
| Beta(). | |
| // Beta(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #693