Fix face bywire bug#94
Closed
kaikokivi wants to merge 2 commits into
Closed
Conversation
Owner
|
This PR did not pass the unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is a typo fix for a logical bug. Input validation lets the invalid wire pass for the IsClosed and valid wire is never tested for IsClosed, it produces a crash. What was probably intended is that it should pass both tests to not to fall into this invalidation statement.
The second commit on the other hand lets the non-closed wire pass to be collected as a wire to be later imprinted on the face. It is a case that perhaps needs addressing although maybe there is another interpretation. I needed in for a JSON serialised topology to come trough. as stored.