make sql file can turn off transaction#133
Open
taojoe wants to merge 3 commits intoweavejester:masterfrom
Open
make sql file can turn off transaction#133taojoe wants to merge 3 commits intoweavejester:masterfrom
taojoe wants to merge 3 commits intoweavejester:masterfrom
Conversation
Owner
|
Thank you for the PR, however I'd rather we didn't add more special meaning to the filename. I'd consider implementing this as a specially-formatted comment but I'd need to think about it. Also commit messages should be written in English and according to the contributing guidelines, and the commits should pass CI. |
Author
|
it's not file name, it's file content starts with. |
Owner
|
Sorry, I misunderstood you previously. I think I'd prefer a comment like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when an sql file starts with "--transaction-off", means turn transaction off.
and print every sql when migrate.