allow URL-unsafe characters inside raw JDBC connection-uri#31
allow URL-unsafe characters inside raw JDBC connection-uri#31gerrit-hntschl wants to merge 1 commit intoweavejester:masterfrom
Conversation
|
What happens when the password is percent-encoded? In theory JDBC should be decoding any percent-encoded passwords. |
|
Received an error because of |
|
What database are you using? |
|
Actually calling |
|
PostgreSQL |
|
Which version of Postgres? |
|
9.3.3 and driver |
|
Okay, I'll run some tests when I get a spare minute. I want to ensure that Postgres really does handle URLs incorrectly before adding any hacks to get around this. In the meantime, you can use |
|
Yeah, we just changed the password 🙈 so we can use lein ragtime migrate during deployments. Thanks! |
ragtime.core/connectiontries to parse the raw-connection-string as a URI which fails if the string contains unsafe characters like%.Our password contained such characters which lead to
java.net.URISyntaxException: Malformed escape pair ...when trying to runlein ragtime migrate.Not sure if proposed fix is a hack, otherwise unsafe characters would have to be percent-encoded inside the project.clj/profiles.clj and parsed inside ragtime, which only adds confusion IMHO.
Cheers!