Skip to content

feat: support resolver #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: support resolver #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23713e8
feat: support resolver
yifancong Nov 17, 2025
1dd821a
feat: support resolver analysis on Rspack
yifancong Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/modern-minimal/modern.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default defineConfig({
},
},
disableClientServer: !process.env.ENABLE_CLIENT_SERVER,
features: ['bundle', 'plugins', 'loader'],
features: ['bundle', 'plugins', 'loader', 'resolver'],
},
]);
},
Expand Down
177 changes: 86 additions & 91 deletions packages/components/src/components/Resolver/analysis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
/* eslint-disable react/no-unescaped-entities */
import {
CloseCircleOutlined,
FileSearchOutlined,
MenuFoldOutlined,
MenuUnfoldOutlined,
} from '@ant-design/icons';
import { CloseCircleOutlined, FileSearchOutlined } from '@ant-design/icons';
import { SDK } from '@rsdoctor/types';
import { Resolver } from '@rsdoctor/utils/common';
import { Button, Card, Col, Row, Space, Table, Typography } from 'antd';
import { Card, Col, Row, Space, Table, Tabs, Typography } from 'antd';
import { get } from 'es-toolkit/compat';
import React, { useMemo, useState } from 'react';
import { Size } from '../../constants';
Expand All @@ -22,91 +17,91 @@ const height = 735;
const ResolverDetailsPanel: React.FC<
SDK.ServerAPI.InferResponseType<SDK.ServerAPI.API.GetResolverFileDetails>
> = ({ filepath, before, after, resolvers }) => {
const [collapsed, setCollapsed] = useState(false);

return (
<React.Fragment>
<Col flex={1}>
<Card
title="Resolve Diff Viewer"
styles={{ body: { padding: 0, overflow: 'hidden' } }}
>
<DiffViewer
style={{
height: height + 50,
}}
isEmbed
originalFilePath={filepath}
modifiedFilePath={filepath}
original={before}
modified={after}
/>
</Card>
</Col>
<Col span={collapsed ? 2 : 7}>
<Card
title={collapsed ? '...' : 'Resolve Details'}
extra={
<Button
onClick={() => setCollapsed(!collapsed)}
size="small"
icon={collapsed ? <MenuFoldOutlined /> : <MenuUnfoldOutlined />}
></Button>
}
style={collapsed ? { width: 80 } : undefined}
>
{collapsed ? null : (
<Table
style={{
width: '100%',
height,
overflowY: 'scroll',
wordBreak: 'break-all',
}}
size="small"
pagination={false}
bordered
rowKey={(e) => e.request}
columns={[
{
title: 'Source Code',
width: 200,
render: (_v, r) => (
<Typography.Text copyable>
<Typography.Text code strong>
{r.request}
</Typography.Text>
</Typography.Text>
),
},
{
title: 'Duration',
width: 80,
render: (_v, r) => (
<Typography.Text strong>
{formatCosts(r.costs)}
</Typography.Text>
),
sorter: (a, b) => a.costs - b.costs,
sortDirections: ['descend', 'ascend'],
},
{
title: 'Resolve Result',
render: (_v, r) => {
if (Resolver.isResolveSuccessData(r))
return (
<Typography.Text copyable>{r.result}</Typography.Text>
);
return <CloseCircleOutlined style={{ color: '#f50' }} />;
},
},
]}
dataSource={resolvers}
/>
)}
</Card>
</Col>
</React.Fragment>
<Col flex={1}>
<Tabs
Copy link

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Tabs component should include an aria-label or aria-labelledby attribute to provide context for screen reader users navigating between the diff viewer and resolver details tabs.

Suggested change
<Tabs
<Tabs
aria-label="Diff viewer and resolver details tabs"

Copilot uses AI. Check for mistakes.
defaultActiveKey="diff"
items={[
{
key: 'diff',
label: 'Resolve Diff Viewer',
children: (
<Card styles={{ body: { padding: 0, overflow: 'hidden' } }}>
<DiffViewer
style={{
height: height + 50,
}}
isEmbed
originalFilePath={filepath}
modifiedFilePath={filepath}
original={before}
modified={after}
/>
</Card>
),
},
{
key: 'details',
label: 'Resolve Details',
children: (
<Card>
<Table
style={{
width: '100%',
height,
overflowY: 'scroll',
wordBreak: 'break-all',
}}
size="small"
pagination={false}
bordered
rowKey={(e) => e.request}
columns={[
{
title: 'Source Code',
width: 200,
render: (_v, r) => (
<Typography.Text copyable>
<Typography.Text code strong>
{r.request}
</Typography.Text>
</Typography.Text>
),
},
{
title: 'Duration',
width: 80,
render: (_v, r) => (
<Typography.Text strong>
{formatCosts(r.costs)}
</Typography.Text>
),
sorter: (a, b) => a.costs - b.costs,
sortDirections: ['descend', 'ascend'],
},
{
title: 'Resolve Result',
render: (_v, r) => {
if (Resolver.isResolveSuccessData(r))
return (
<Typography.Text copyable>
{r.result}
</Typography.Text>
);
return (
<CloseCircleOutlined style={{ color: '#f50' }} />
);
},
},
]}
dataSource={resolvers}
/>
</Card>
),
},
]}
/>
</Col>
);
};

Expand Down
8 changes: 6 additions & 2 deletions packages/components/src/pages/ModuleResolve/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@ export const Page: React.FC = () => {
return (
<div>
<Card
title="Webpack Resolver Analysis"
extra={<WebpackConfigurationViewer defaultKeys={['resolve', 'resolveLoader']} />}
title="Resolver Analysis"
extra={
<WebpackConfigurationViewer
defaultKeys={['resolve', 'resolveLoader']}
/>
}
bodyStyle={{ paddingTop: 0 }}
>
<ResolverAnalysis />
Expand Down