Fix #55888 #55889
Open
Fix #55888 #55889
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've removed the src attribute from img to not trigger an immediate load. The spec says that only when javascript is running, source file, line number and column should be reported as per 2.4.1 https://w3c.github.io/webappsec-csp/#create-violation-for-global in step 2. This change will make the load happen when script is actually running, on line 54 and line 54 should therefore be reported.
theIDinside
commented
Nov 5, 2025
| theImage.src = '/content-security-policy/support/fail.png' | ||
| </script> | ||
|
|
||
| <script async defer src='../support/checkReport.sub.js?reportField=effectiveDirective&reportValue=img-src%20%27none%27'></script> |
Contributor
Author
There was a problem hiding this comment.
This is the line number it would previously report for. Which does not make much sense and chrome is returning information that will not make sense for the end user here, because the violation actualy happens on line 49, inside the <img> tag.
theIDinside
commented
Nov 9, 2025
| assert_equals(reports[0].body.statusCode, 200); | ||
| assert_equals(reports[0].body.lineNumber, 53); | ||
| assert_equals(reports[0].body.lineNumber, 54); | ||
| assert_equals(reports[0].body.columnNumber, 0); |
Contributor
Author
There was a problem hiding this comment.
This (the column value) would also change now that I think about it, to 5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the test described in #55888 that seemingly breaks with spec. This is a suggested edit, as it still keeps what the original test intends to test for, but a test should probably also be written, where this test returns source file null and line/column numbers as 0/null.
We've removed the src attribute from img to not trigger an immediate load. The spec says that only when javascript is running, source file, line number and column should be reported as per 2.4.1 https://w3c.github.io/webappsec-csp/#create-violation-for-global in step 2.
This change will make the load happen when script is actually running, on line 54 and line 54 should therefore be reported.