[css-lists] Apply new algorithm for initial counter in reversed list #55958
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL applies the last non-zero increment version algorithm[1] that accounts an initial counter value. If we have an explicit start value, we don't apply a counter increment of the list item. E.g., if the list is reversed, then plus one, else minus one to the initial counter value. This is same as Firefox's behaviour. And this CL renames functions which is related an instantiating counters to `InitialCounter*` for aligning with the spec. [1]: w3c/csswg-drafts#6797 Bug: 40682542 Change-Id: I8188288062461ca4c5689e530db3255f9c31ebcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7126701 Commit-Queue: Minseong Kim <[email protected]> Reviewed-by: Daniil Sakhapov <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Cr-Commit-Position: refs/heads/main@{#1542452}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7126701
branch
from
48cbeb6 to
0608332
Compare
wpt-pr-bot
approved these changes
Nov 10, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL applies the last non-zero increment version algorithm1 that
accounts an initial counter value.
If we have an explicit start value, we don't apply a counter increment
of the list item. E.g., if the list is reversed, then plus one, else
minus one to the initial counter value. This is same as Firefox's
behaviour.
And this CL renames functions which is related an instantiating counters
to
InitialCounter*for aligning with the spec.Bug: 40682542
Change-Id: I8188288062461ca4c5689e530db3255f9c31ebcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7126701
Commit-Queue: Minseong Kim <[email protected]>
Reviewed-by: Daniil Sakhapov <[email protected]>
Reviewed-by: Rune Lillesveen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1542452}