Update sanitizer-boolean-defaults to match current spec. #55959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilpie
requested changes
Nov 11, 2025
Contributor
evilpie
left a comment
evilpie
left a comment
There was a problem hiding this comment.
Isn't this missing a test for { attributes: [] } where dataAttributes is automatically added?
Member
Author
Done. |
evilpie
approved these changes
Nov 13, 2025
otherdaniel
merged commit 676bf0e
into
web-platform-tests:master
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sanitizer-api/sanitizer-boolean-defaults.tentative.html to match the current spec. In particular, adapt to the behaviour that
dataAttributecannot be set whenremoveAttributesis also set.I've re-arranged the order of test cases under 4 blocks each, for parameter-less construction, empty dict, and explicitly true and false. I hope this makes it easier to understand what's going on.