Injectable ApplyAdminCustomDomains and ApplyApiCustomDomains Services#5201
Open
adrians5j wants to merge 12 commits into
Open
Injectable ApplyAdminCustomDomains and ApplyApiCustomDomains Services#5201adrians5j wants to merge 12 commits into
adrians5j wants to merge 12 commits into
Conversation
adrians5j
changed the title
… github.com:webiny/webiny-js into adrian/pulumi-custom-domain-abstractions-2026-05-12 # Conflicts: # packages/project-aws/src/pulumi/apps/admin/createAdminPulumiApp.ts # packages/project-aws/src/pulumi/apps/api/createApiPulumiApp.ts
… github.com:webiny/webiny-js into adrian/pulumi-custom-domain-abstractions-2026-05-12
… github.com:webiny/webiny-js into adrian/pulumi-custom-domain-abstractions-2026-05-12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Introduces two new injectable DI services —
ApplyAdminCustomDomainsandApplyApiCustomDomains— that allow users to apply custom CloudFront domain configuration from within a singleAdminPulumiorApiPulumiimplementation file. Previously, there was no supported way to wire dynamically-created Pulumi resources (e.g. Route53 records, ACM certificates) to the CloudFront custom domain setup; users had to hardcode values in the staticInfra.Admin.CustomDomainsJSX extension. The Pulumi execution model for both apps is also updated so implementations run before the CloudFront resource is created, which is required for config modifications to take effect.Changelog
Dynamically Apply Custom Domains in Admin and API Pulumi Implementations
Custom CloudFront domain configuration can now be applied dynamically from within a standard
AdminPulumiorApiPulumiimplementation by injecting the newApplyAdminCustomDomainsorApplyApiCustomDomainsservice. This makes it possible to create Route53 records and ACM certificates in the same file and wire their Pulumi outputs directly to the CloudFront distribution, without needing hardcoded values or multiple files.Squash Merge Commit