feat(app-admin): subscribe admin user to newsletter after install#5240
Merged
Conversation
After a successful system install, fire-and-forget POST the admin user's name + email (already collected in the AdminUserStep) to t.webiny.com/newsletter, which forwards to MailerLite. Skipped when REACT_APP_WEBINY_TELEMETRY=false or when the Cognito step did not run. Failures are swallowed so the wizard never blocks on the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The newsletter subscription logic has been extracted from the System Installer presenter into an injectable
NewsletterSubscriptionService. The service now checks the telemetry enabled flag viaEnvConfiginstead of readingprocess.envdirectly, making it consistent with the rest of the application.Changelog
Newsletter subscription refactored into an injectable service
The newsletter subscription during installation was previously handled as a private method inside the presenter. It is now a standalone injectable service, making it easier to test and reuse. The telemetry gating also now uses the application config instead of raw environment variables.
Squash Merge Commit