Skip to content

Conversation

@leoherzog
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added support for decoding and encoding of infoHashV2 key for BitTorrent v2 Support.

Which issue (if any) does this pull request address?
#88

Is there anything you'd like reviewers to focus on?
I need a hand updating the tests. I'm not familiar with tape, and I suspect that there are at least a couple of assumptions made in testing that each Torrent object should always must have an infoHash key. The new assumption is a valid object can have an infoHash key, or an infoHashV2 key, or both.

@welcome
Copy link

welcome bot commented May 12, 2021

🙌 Thanks for opening this pull request! You're awesome.

@DiegoRBaquero
Copy link
Member

The assumption is valid, it should have either v1 or v2, or both.

@DiegoRBaquero DiegoRBaquero self-assigned this Jun 2, 2021
@DiegoRBaquero DiegoRBaquero changed the title Initial Stab at BitTorrent v2 Support feat: BitTorrent v2 Support Aug 11, 2021
@leoherzog
Copy link
Contributor Author

Hey reviewers. What's left to be done to advance this PR?

@feross @DiegoRBaquero

@sneakers-the-rat
Copy link

sneakers-the-rat commented May 27, 2025

checking in on this - looks like this is a prerequisite to webtorrent/webtorrent#1117

is @leoherzog still around? or should i take this over?

@leoherzog
Copy link
Contributor Author

I haven't touched this in years and I suspect it would need a complete rethinking. If you want to take a crack at it, go for it.

@sneakers-the-rat
Copy link

It looks fine! We will need to handle the file tree and the piece layers in the parsing method, but what's here already looks like the top-level integration we need for recognizing them and grabbing infohashes :)

I'll get working on this tomorrow.

@leoherzog
Copy link
Contributor Author

Perhaps before you put any more time into it, confirm with @DiegoRBaquero or @feross or someone that they're interested in accepting PRs. I was met with silence.

package.json Outdated
"simple-get": "^4.0.1",
"simple-sha1": "^3.1.0"
"simple-sha1": "^3.1.0",
"simple-sha256": "^1.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

congratulations, you opened pandora's box, this needs to be deprecated in favor of uint8-utils async hash() function, which means making the entire program async! have fun :^)

@ThaUnknown
Copy link
Member

Perhaps before you put any more time into it, confirm with @DiegoRBaquero or @feross or someone that they're interested in accepting PRs. I was met with silence.

because they left webtorrent behind at that time, you also didn't include testing, as of now i'm pretty much the only person maintaining webtorrent, sometimes with the help of silentbot1

@leoherzog
Copy link
Contributor Author

Took another stab at this with PR #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants