-
-
Notifications
You must be signed in to change notification settings - Fork 86
feat: BitTorrent v2 Support #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The assumption is valid, it should have either v1 or v2, or both. |
|
Hey reviewers. What's left to be done to advance this PR? |
|
checking in on this - looks like this is a prerequisite to webtorrent/webtorrent#1117 is @leoherzog still around? or should i take this over? |
|
I haven't touched this in years and I suspect it would need a complete rethinking. If you want to take a crack at it, go for it. |
|
It looks fine! We will need to handle the file tree and the piece layers in the parsing method, but what's here already looks like the top-level integration we need for recognizing them and grabbing infohashes :) I'll get working on this tomorrow. |
|
Perhaps before you put any more time into it, confirm with @DiegoRBaquero or @feross or someone that they're interested in accepting PRs. I was met with silence. |
package.json
Outdated
| "simple-get": "^4.0.1", | ||
| "simple-sha1": "^3.1.0" | ||
| "simple-sha1": "^3.1.0", | ||
| "simple-sha256": "^1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
congratulations, you opened pandora's box, this needs to be deprecated in favor of uint8-utils async hash() function, which means making the entire program async! have fun :^)
because they left webtorrent behind at that time, you also didn't include testing, as of now i'm pretty much the only person maintaining webtorrent, sometimes with the help of silentbot1 |
|
Took another stab at this with PR #193 |

What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added support for decoding and encoding of
infoHashV2key for BitTorrent v2 Support.Which issue (if any) does this pull request address?
#88
Is there anything you'd like reviewers to focus on?
I need a hand updating the tests. I'm not familiar with
tape, and I suspect that there are at least a couple of assumptions made in testing that each Torrent object should always must have aninfoHashkey. The new assumption is a valid object can have aninfoHashkey, or aninfoHashV2key, or both.