-
Notifications
You must be signed in to change notification settings - Fork 25
Postgresql integration #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Denes-cilwal
wants to merge
22
commits into
develop
Choose a base branch
from
postgresql-integration
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
[WIP] Update database provider interface based on feedback
[WIP] Update implementation based on feedback for database provider interface
…-one [WIP] Address feedback on database provider interface implementation
Co-authored-by: Denes-cilwal <[email protected]>
Co-authored-by: Denes-cilwal <[email protected]>
…-one [WIP] Address feedback on database provider interface implementation
… to use nested structs
…tions and remove MySQL-specific code
paudelgaurav
requested changes
Nov 4, 2025
|
|
||
| // User model | ||
| type User struct { | ||
| gorm.Model |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Denes-cilwal Let's use uuid as PK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the codebase from MySQL to PostgreSQL, refactors environment variable usage, and updates related configuration, infrastructure, and dependency files. The changes ensure compatibility with PostgreSQL, improve environment config structure, and update Docker and migration tooling accordingly.
Database Migration and Configuration Updates:
.env.example,docker-compose.yml,atlas.hcl, and migration files. Updated environment variables and connection ports to match PostgreSQL conventions. [1] [2] [3] [4] [5] [6]pkg/infrastructure/db.goto use PostgreSQL driver, add validation for database names, and implement logic for creating/checking the target database in PostgreSQL. The database connection setup now usesgorm.io/driver/postgres.Dependency and Tooling Updates:
go.modto usegorm.io/driver/postgresinstead of MySQL, removed direct MySQL driver dependency, and adjusted indirect dependencies accordingly. [1] [2] [3] [4]Makefileto use PostgreSQL connection strings and Atlas migration commands compatible with PostgreSQL.Environment and Configuration Refactoring:
pkg/framework/env.goto group environment variables into structured config types (ServerConfig,DatabaseConfig,SentryConfig,AWSConfig,AdminConfig), and updated usage throughout the codebase for improved clarity and maintainability. [1] [2] [3] [4]Codebase Adjustments for PostgreSQL:
UUIDfield and itsBeforeCreatehook indomain/models/user.go). [1] [2]Docker and Service Orchestration:
docker-compose.yml, updated health checks, and adjusted service dependencies and networks. Updated Adminer configuration for PostgreSQL. [1] [2]References:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21]