Skip to content

Match PR/issue number when filtering the sidebar by search#279

Merged
mariusvniekerk merged 2 commits intomainfrom
middleman/issue-278
May 8, 2026
Merged

Match PR/issue number when filtering the sidebar by search#279
mariusvniekerk merged 2 commits intomainfrom
middleman/issue-278

Conversation

@mariusvniekerk
Copy link
Copy Markdown
Collaborator

@mariusvniekerk mariusvniekerk commented May 7, 2026

Summary

Closes #278

🤖 Generated with Claude Code

@mariusvniekerk
Match PR/issue number when filtering the sidebar by search
f15ae96 
The sidebar search box only matched title and author, so typing a PR
or issue number returned an empty list. Build the search target as
"#{number} {title}" so a substring search hits the number, the title,
or both, and users can paste references like "#278" directly.

Closes #278
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (f15ae96)

Search-by-number change looks safe, but it is missing required end-to-end coverage.

Medium

  • internal/db/queries_test.go:1482 / Global: Search behavior changed for user-visible sidebar/API filtering, but coverage was added only at the DB query layer. This can regress between HTTP search parameters, SQLite queries, and frontend/sidebar behavior without being caught.
    • Fix: Add an e2e/full-stack test that seeds PRs/issues, calls the real list/search flow with numeric and #number search terms, and verifies filtered results for both PRs and issues.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk @claude
test: cover sidebar search-by-number through the HTTP API
4d79345 
The number-aware sidebar search was only exercised at the DB query layer,
leaving the HTTP search parameter, SQLite query, and frontend-facing list
shape uncovered as a unit. Add full-stack tests that seed PRs and issues
with non-numeric titles and call /pulls and /issues with numeric and
"#number" search terms so a regression in any of those layers fails CI.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 7, 2026

roborev: Combined Review (4d79345)

All reviewers found the PR clean with no Medium, High, or Critical issues.

The change adds numeric search support for PRs and issues, with database and HTTP API coverage, and keeps user input parameterized.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@mariusvniekerk mariusvniekerk merged commit 92340d9 into main May 8, 2026
14 of 17 checks passed
@mariusvniekerk mariusvniekerk deleted the middleman/issue-278 branch May 8, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filtering in the PR/Sidebar by issue number does not work

1 participant

@mariusvniekerk