Fix broken siphash implementation #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credit: Bryan Silverthorn, emboss/siphash-java#2
Collaborator
|
whoa, interesting. evaluating! Thank you |
uhtu
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses a broken java implementation of siphash from https://github.com/emboss/siphash-java which makes the m8b files produced unusable with systems which use a correct siphash.
The siphash-java project has had on open pull request with a fix for this issue for close to a decade, but that project is dead.
This PR contains the fix applied to the siphash java sources in m8b.
Could you please apply the fix and make a new release of m8binary, with a fresh data import?