Add option to ignore unimplemented tags instead of throwing an error#32
Open
ktrask wants to merge 4 commits intowilkelab:masterfrom
Open
Add option to ignore unimplemented tags instead of throwing an error#32ktrask wants to merge 4 commits intowilkelab:masterfrom
ktrask wants to merge 4 commits intowilkelab:masterfrom
Conversation
Collaborator
|
That seems a bit over-engineered. I think it's fine to just replace the error with a warning. The main reason why I put the error there was I didn't want hundreds of bug reports that certain things don't render correctly when there was never any support of those features to begin with. But a warning communicates that just the same. (In my experience from teaching R to hundreds of undergrads, they typically think a warning is an error anyways.) |
Author
|
Thank you for the feedback! I have changed the code accordingly and just changed the error to a warning about unimplemented tags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a the error message
Error: gridtext has encountered a tag that isn't supported yet: <code>while not adding this<code>tag anywhere. It came because sometimes ggplot adds backticks in some cases in axis labels. And the backticks are evaluated by the markdown package to<code>-tags.Also I cannot control all the labels that are used in the software I want to use gridtext/ggtext in, I wanted the option to prevent gridtext to stop on unknown tags. So I added it.
Example: