Open
Conversation
Previously, make_syntax_validator() created a new Lark parser for each rule, which was expensive (~660ms total import time). This change: - Defines ALL_START_RULES containing all grammar rules needed by validators - Creates a single shared syntax_parser with all start rules upfront - Refactors make_syntax_validator() to use functools.partial with is_valid_syntax() instead of creating new parsers Import time reduced from ~660ms to ~72ms (9x speedup). Testing protocol: - Created timing script that clears module cache and measures import time - Ran 5 iterations for each version to account for variance - Used git stash to preserve dirty state while testing HEAD - Results: HEAD averaged ~662ms, this change averages ~72ms - All existing tests pass (2/2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried again lazy import (#8) after #11:
For this branch (lazy import):
To be compared with, for agentydragon:adgn/one-parser
and for main: