[codex] fix allowlist case-insensitive lookup#642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetAllowlistbefore reading the stored allowlist map.Root Cause
SetAllowlistlowercased integration names when storing allowlist entries, butGetAllowlistused the caller-provided name as-is. Direct mixed-case lookups could incorrectly return an empty allowlist even though one was configured.Impact
The current proxy path passes the already-normalized integration name, so this was primarily a latent correctness issue. Fixing it keeps allowlist retrieval consistent with integration and denylist lookups and prevents future callers from accidentally treating a configured allowlist as absent.
Validation
go test ./app -run TestGetAllowlistCaseInsensitive -count=1go test ./...go vet ./...