Skip to content

[codex] log XFCC auth failure headers#647

Merged
winhowes merged 2 commits intomainfrom
codex/log-xfcc-auth-failure-headers
May 8, 2026
Merged

[codex] log XFCC auth failure headers#647
winhowes merged 2 commits intomainfrom
codex/log-xfcc-auth-failure-headers

Conversation

@winhowes
Copy link
Copy Markdown
Owner

@winhowes winhowes commented May 8, 2026

Summary

  • Add an auth-plugin logger that is wired to the main service logger.
  • Log all request headers when the envoy_xfcc plugin fails incoming authentication.
  • Cover failure logging, success no-log behavior, invalid params, identify failure, and logger accessor behavior.

Impact

Operators get the full incoming header context when XFCC auth fails, while successful authentication stays quiet.

Validation

  • go test ./app/auth ./app/auth/plugins/envoy_xfcc -coverprofile=/tmp/xfcc-auth.cover
    • app/auth: 100.0% statements
    • app/auth/plugins/envoy_xfcc: 100.0% statements
  • go tool cover -func=/tmp/xfcc-auth.cover: total 100.0%
  • go test ./app/auth ./app/auth/plugins/envoy_xfcc -count=5
  • go test ./... -run '^$' -count=1
  • go test -coverprofile=/tmp/authtranslator.cover ./... produced a profile with total 100.0% statement coverage, but exited nonzero locally because TestWatchFilesRename timed out waiting for a write event after rename in this checkout.

@winhowes winhowes marked this pull request as ready for review May 8, 2026 17:47
@winhowes winhowes marked this pull request as draft May 8, 2026 17:59
@winhowes winhowes marked this pull request as ready for review May 8, 2026 18:02
@winhowes winhowes merged commit 98a5039 into main May 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant