refactor: externalize Arcs and make CoreCrypto: !Clone [WPB-25220]#2107
Open
coriolinus wants to merge 4 commits intomainfrom
Open
refactor: externalize Arcs and make CoreCrypto: !Clone [WPB-25220]#2107coriolinus wants to merge 4 commits intomainfrom
Arcs and make CoreCrypto: !Clone [WPB-25220]#2107coriolinus wants to merge 4 commits intomainfrom
Conversation
We don't actually need or want this, essentially ever. So let's get rid of it. What we really want is a single Arc which captures the whole thing.
We want an `Arc<CoreCrypto>` essentially every time instead of cloning; this implements that.
CC keeps an outer `Arc` now, so we no longer need the inner ones. The biggest change happened with Proteus, because that one (only) used to have an accessor which depended on cheap clones to pass out references. We just removed that for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Note: we'd do something similar for
Database, externalizing its internalArcs, but that ends up with a problem. For context, eachCoreCryptoinstance + several other places need to store anArc<Database>, not just aDatabase, because we have to copy the database around into a bunch of places. Unfortunately, the ProteusPreKeyStoretrait takes mutable references, which would mean that all those places need to store some kind ofArc<RwLock<Database>>, and at that point the cost-benefit analysis kind of stops being worth it.PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.