Skip to content

WPB-16060: set production-like default Helm values for shutdownGracePeriod#24

Open
lwille wants to merge 1 commit intorelease-5.0from
WPB-16060/default-values
Open

WPB-16060: set production-like default Helm values for shutdownGracePeriod#24
lwille wants to merge 1 commit intorelease-5.0from
WPB-16060/default-values

Conversation

@lwille
Copy link
Copy Markdown
Contributor

@lwille lwille commented Apr 8, 2025


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We always needed to override these values per environment. Since SFT supports draining, we can now confidently set a high default shutdownGracePeriod which should be appropriate for all environments.

Testing

How to Test

This was already tested by overriding the values from Terraform and applying to staging.

@lwille lwille requested a review from a team as a code owner April 8, 2025 17:41
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2025

@lwille lwille changed the base branch from main to release-5.0 April 8, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants