WPB-16060: set production-like default Helm values for shutdownGracePeriod#24
Open
lwille wants to merge 1 commit intorelease-5.0from
Open
WPB-16060: set production-like default Helm values for shutdownGracePeriod#24lwille wants to merge 1 commit intorelease-5.0from
lwille wants to merge 1 commit intorelease-5.0from
Conversation
|
smatting
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
We always needed to override these values per environment. Since SFT supports draining, we can now confidently set a high default shutdownGracePeriod which should be appropriate for all environments.
Testing
How to Test
This was already tested by overriding the values from Terraform and applying to
staging.