feat: multiple media selection on Drive conversations - WPB-24046 by jullianm · Pull Request #4613 · wireapp/wire-ios

jullianm · 2026-04-22T15:13:09Z

WPB-24046 [iOS] Improve sending multiple images on iOS

Issue

Currently user has to select each image from the gallery (custom and native one) one by one and approve it in full screen view.

This PR introduces changes to allow the user to frictionlessly upload multiple media at once.

Overview

On selection of assets from the custom gallery (at the bottom), assets are now directly attached - no full screen confirmation.
Multiple assets can be selected and they are easily identifiable from the custom gallery (checkmarked). They can be deselected which automatically removes the related drafts from the preview.
Full screen confirmation now only opens on tap of the attached asset (image or video)
When the asset (image) is edited on that confirmation screen, it updates the attached asset.
The native PHPickerViewController is introduced to allow multiple media selection (previously UIImagePickerController was used)

Testing

Wire drive conversations

Hit camera icon button
Select multiple media image / video, observe that full screen confirmation screen no longer opens but selected media are directly attached and uploaded.
Hit “files” icon button, select multiple files and validate.
In the input bar, tap on image attachment, it now opens full screen confirmation, edit the image (draw something), tap “OK”, attachment image will be upated. Tapping “OK” or “Cancel” on an un-edited image will simply dimiss the screen
Tap again on that updated attachment to check that asset has been correctly updated.
Tap on a video attachment, observe that it opens the same full screen view, “OK” or “Cancel” simply dismisses the screen.
Tap on file attachment, observe that it doesn’t open anything..
In the media scrollable view, hit the “Gallery” icon button, it should open the native gallery screen allowing multiple media selection
Select multiple media (videos/images), validate and observe selected media are correctly attached.
Take a picture with the camera, observe that the draft is correctly attached
Remove some attachments and attach new media based on the previous use cases to ensure drafts behaviour is preserved.

Non-Wire drive conversations (non regression test)

Behaviour should be as before as nothing was changed for these conversations.

Checklist

Title contains a reference JIRA issue number like [WPB-XXX].
Description is filled and free of optional paragraphs.
Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

Make sure you use the API for UI elements that support large fonts.
All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
New UI elements have Accessibility strings for VoiceOver.

…e uploaded asset after editing (wip)

…rom picker, handle media edition, fix issue on tap.

github-actions · 2026-04-22T16:51:13Z

Test Results

4 552 tests 4 525 ✅ 7m 40s ⏱️
601 suites 27 💤
3 files 0 ❌

Results for commit 35d830e.

♻️ This comment has been updated with latest results.

Summary: workflow run #25305822495
Allure report (download zip): html-report-29641-feat_drive-multiple-media-selection

…m/wireapp/wire-ios into feat/drive-multiple-media-selection

johnxnguyen

Looks good, left a couple questions.

johnxnguyen · 2026-05-04T13:59:50Z

+                guard error == nil, let url else { return }
+                self.uploadFiles(at: [url])


question: does the temp directory need to be cleanup here too?

I extracted the legacy code into a separated reusable function here however you might be right.. I'll check it

netbe · 2026-05-06T08:31:11Z

-            }
+            if useWireDrive(), sourceType != .camera {
+                // Allows multiple media selection on Wire drive conversations.
+                // Non-drive conversations use the (legacy) `UIImagePickerController` API.


question: would it be possible to use PHPicker on other conversations? I know it might be out of scope, but just wonder how big would be the change? maybe on a separate PR?

yes it would be possible but only for photos: PHPickerViewController doesn't handle camera.
The UIImagePickerController handles both.

We'll always end up with two different APIs to use however it might make more sense to use the PHPickerViewController for photos (all conversations) and continue to use UIImagePickerController (or another API) only for camera.

I don't think this would be too difficult to change (separated task / PR).

OlivellaO · 2026-05-06T11:52:07Z


        let draft = WireDriveDraft(
-            nodeID: UUID(),
+            nodeID: nodeID ?? UUID(),


If we need an UUID to create a WireDriveDraft, why is it not mandatory on the invoke function?
Maybe there is a reason for it but I would prefer to avoid nullability and avoid assigning this UUID in different places (default value on SendableImage & ConversationInputBarViewController if provided by draft object).
We could remove the default value on SendableImage and if draft.nodeId is null just use UUID()

this is optional because sometimes the draft doesn't exist and we create it from scratch, and sometimes it does and we want to update it. I agree the naming is confusing here, I will find something better.

done, the naming is a bit more explicit and gives more context on why it can be optional.

OlivellaO

Approved with question

…ed drafts uploads (native picker) adjust send button in edition screen

WilhelmOks

LGTM. Added a few comments.

…m/wireapp/wire-ios into feat/drive-multiple-media-selection

github-actions · 2026-05-06T14:58:02Z

Test Results – WireMessagingAll

302 tests 302 ✅ 1m 3s ⏱️
59 suites 0 💤
1 files 0 ❌

Results for commit 690ac06.

♻️ This comment has been updated with latest results.

github-actions · 2026-05-06T15:03:52Z

Test Results – Wire-iOS

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 690ac06.

♻️ This comment has been updated with latest results.

jullianm · 2026-05-06T15:19:44Z

@netbe @johnxnguyen @WilhelmOks @OlivellaO FYI, I made some improvements / fixes following the PT, these are visible in this single commit: 700d393

Handle drafts selection/deselection on the custom picker: making it visible to the user (checkmark icon) and automatically synchronizing it with the draft preview (when asset is deselected, the draft preview is automatically removed)
Prevent duplicated drafts uploads from the native picker
Adjust send button in edition screen

Feel free to review it if you want.

sonarqubecloud · 2026-05-06T15:25:19Z

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-05-06T15:29:37Z

Test Results – WireUIAll

161 tests 160 ✅ 1m 14s ⏱️
41 suites 1 💤
1 files 0 ❌

Results for commit 690ac06.

github-actions · 2026-05-06T16:19:30Z

Test Results – WireDataModel

2 377 tests 2 377 ✅ 3m 49s ⏱️
245 suites 0 💤
1 files 0 ❌

Results for commit 690ac06.

jullianm added 3 commits April 21, 2026 09:03

open full screen media on draft preview tap, handle logic to overwrit…

4512b10

…e uploaded asset after editing (wip)

introduce PHPicker to allow multiple media selection, process media f…

fb025e8

…rom picker, handle media edition, fix issue on tap.

clean up code

ff6521b

github-actions Bot assigned jullianm Apr 22, 2026

jullianm requested review from a team, David-Henner, WilhelmOks and netbe and removed request for a team April 22, 2026 15:15

Merge branch 'develop' into feat/drive-multiple-media-selection

d5c846d

jullianm requested a review from OlivellaO April 22, 2026 15:16

jullianm and others added 2 commits April 27, 2026 11:23

Merge branch 'develop' into feat/drive-multiple-media-selection

37c4222

fix UT compilation issues

eae880a

jullianm requested review from johnxnguyen April 27, 2026 09:58

jullianm and others added 4 commits April 27, 2026 13:50

Merge branch 'develop' into feat/drive-multiple-media-selection

8a00bb4

fix UT compilation issue

4c59812

Merge branch 'feat/drive-multiple-media-selection' of ssh://github.co…

1c27a83

…m/wireapp/wire-ios into feat/drive-multiple-media-selection

Merge branch 'develop' into feat/drive-multiple-media-selection

35d830e

johnxnguyen reviewed May 4, 2026

View reviewed changes

jullianm removed request for David-Henner and netbe May 6, 2026 08:30

netbe reviewed May 6, 2026

View reviewed changes

OlivellaO reviewed May 6, 2026

View reviewed changes

OlivellaO approved these changes May 6, 2026

View reviewed changes

handle drafts selection/deselection (custom picker), prevent duplicat…

700d393

…ed drafts uploads (native picker) adjust send button in edition screen

WilhelmOks approved these changes May 6, 2026

View reviewed changes

Comment thread ...g/Sources/WireMessagingUI/WireDrive/Components/AttachmentsCarousel/AttachmentsCarousel.swift Outdated

Comment thread .../WireMessagingUI/WireDrive/Components/AttachmentsCarousel/AttachmentsCarouselViewModel.swift Outdated

jullianm and others added 2 commits May 6, 2026 16:25

Merge branch 'develop' into feat/drive-multiple-media-selection

8cb511a

add code doc

f493c3b

Merge branch 'feat/drive-multiple-media-selection' of ssh://github.co…

a3d2034

…m/wireapp/wire-ios into feat/drive-multiple-media-selection

jullianm and others added 3 commits May 6, 2026 17:03

fix naming

b40002e

fix tests

831ed32

Merge branch 'develop' into feat/drive-multiple-media-selection

690ac06

		guard error == nil, let url else { return }
		self.uploadFiles(at: [url])

Conversation

jullianm commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Testing

Checklist

UI accessibility checklist

Uh oh!

github-actions Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

johnxnguyen left a comment

Choose a reason for hiding this comment

Uh oh!

johnxnguyen May 4, 2026

Choose a reason for hiding this comment

Uh oh!

jullianm May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

netbe May 6, 2026

Choose a reason for hiding this comment

Uh oh!

jullianm May 6, 2026

Choose a reason for hiding this comment

Uh oh!

OlivellaO May 6, 2026

Choose a reason for hiding this comment

Uh oh!

jullianm May 6, 2026

Choose a reason for hiding this comment

Uh oh!

jullianm May 6, 2026

Choose a reason for hiding this comment

Uh oh!

OlivellaO left a comment

Choose a reason for hiding this comment

Uh oh!

WilhelmOks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results – WireMessagingAll

Uh oh!

github-actions Bot commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results – Wire-iOS

Uh oh!

jullianm commented May 6, 2026

Uh oh!

sonarqubecloud Bot commented May 6, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented May 6, 2026

Test Results – WireUIAll

Uh oh!

github-actions Bot commented May 6, 2026

Test Results – WireDataModel

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jullianm commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented Apr 22, 2026 •

edited

Loading

github-actions Bot commented May 6, 2026 •

edited

Loading

github-actions Bot commented May 6, 2026 •

edited

Loading