Skip to content

fix: wire drive refactoring tasks - WPB-21903#4660

Open
WilhelmOks wants to merge 17 commits intodevelopfrom
improvement/WPB-21903-wire-drive-refactoring-tasks
Open

fix: wire drive refactoring tasks - WPB-21903#4660
WilhelmOks wants to merge 17 commits intodevelopfrom
improvement/WPB-21903-wire-drive-refactoring-tasks

Conversation

@WilhelmOks
Copy link
Copy Markdown
Collaborator

@WilhelmOks WilhelmOks commented Apr 30, 2026

Solution

Removed FilenameValidator and replaced by TextValidator which handles all kinds of validations and also provides localized validation error messages.

the snapshot test will be fixed in WPB-25202

Testing

Check if the validation is still correct and the same as it was before in:

  • tags
  • file/folder rename
  • file/folder create

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Test Results

303 tests   290 ✅  4m 19s ⏱️
 60 suites    0 💤
  1 files     13 ❌

For more details on these failures, see this check.

Results for commit c9f130e.

♻️ This comment has been updated with latest results.

Summary: workflow run #25441414539
Allure report (download zip): html-report-29783-improvement_WPB-21903-wire-drive-refactoring-tasks

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Apr 30, 2026

Tests

Fix all issues with Cursor

⚠️ Warnings

🧪 13 Tests failed

hasMore() from WireMessagingTests.FilesViewModelTests   View in Datadog   (Fix with Cursor)
Test crashed with signal trap.
isLoading() from WireMessagingTests.FilesViewModelTests   View in Datadog   (Fix with Cursor)
Test crashed with signal trap.
loadMoreIfNeeded_appendsItems() from WireMessagingTests.FilesViewModelTests   View in Datadog   (Fix with Cursor)
Test crashed with signal trap.
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c9f130e | Docs | Give us feedback!

@WilhelmOks WilhelmOks requested review from OlivellaO and jullianm May 4, 2026 11:51
Copy link
Copy Markdown
Collaborator

@OlivellaO OlivellaO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants