fix: wire drive refactoring tasks - WPB-21903#4660
Open
WilhelmOks wants to merge 17 commits intodevelopfrom
Open
fix: wire drive refactoring tasks - WPB-21903#4660WilhelmOks wants to merge 17 commits intodevelopfrom
WilhelmOks wants to merge 17 commits intodevelopfrom
Conversation
Contributor
Test Results303 tests 290 ✅ 4m 19s ⏱️ For more details on these failures, see this check. Results for commit c9f130e. ♻️ This comment has been updated with latest results. Summary: workflow run #25441414539 |
…ch error it produces in the CI
|
…the one with the expiration date.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Solution
Removed
FilenameValidatorand replaced byTextValidatorwhich handles all kinds of validations and also provides localized validation error messages.the snapshot test will be fixed in WPB-25202
Testing
Check if the validation is still correct and the same as it was before in: