Skip to content

fix(api-client): Remove temporary hack for /websocket prefix [WPB-23436]#20511

Merged
thisisamir98 merged 1 commit intodevfrom
WPB-23436-4
Feb 26, 2026
Merged

fix(api-client): Remove temporary hack for /websocket prefix [WPB-23436]#20511
thisisamir98 merged 1 commit intodevfrom
WPB-23436-4

Conversation

@thisisamir98
Copy link
Collaborator

@thisisamir98 thisisamir98 commented Feb 26, 2026

TaskWPB-23436 [Web] Update WebSocket connection logic to fallback from /websocket to /await on 404

Pull Request

Summary

  • What did I change and why?
    /websocket is no longer needed.

  • Risks and how to roll out / roll back (e.g. feature flags):


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.40%. Comparing base (b1a432f) to head (c7ba1ae).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #20511   +/-   ##
=======================================
  Coverage   45.40%   45.40%           
=======================================
  Files        1637     1637           
  Lines       40364    40360    -4     
  Branches     8334     8332    -2     
=======================================
- Hits        18326    18325    -1     
+ Misses      20101    20100    -1     
+ Partials     1937     1935    -2     
Flag Coverage Δ
app_webapp 43.60% <ø> (+<0.01%) ⬆️
lib_api_client 50.17% <ø> (+<0.01%) ⬆️
lib_core 59.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libraries/api-client/src/tcp/WebSocketClient.ts 70.17% <ø> (+0.68%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 10
  • Failed: 0
  • Skipped: 4
  • 🔁 Flaky: 0
  • 📊 Total: 14
  • Total Runtime: 90.7s (~ 1 min 31 sec)

@thisisamir98 thisisamir98 added this pull request to the merge queue Feb 26, 2026
Merged via the queue into dev with commit 60da9e0 Feb 26, 2026
54 checks passed
@thisisamir98 thisisamir98 deleted the WPB-23436-4 branch February 26, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants