Skip to content

fix(webapp): Implement recovery mechanism for epoch number mismatch between CC and local state [WPB-23452]#20515

Merged
thisisamir98 merged 1 commit intodevfrom
WPB-23452-2
Feb 26, 2026
Merged

fix(webapp): Implement recovery mechanism for epoch number mismatch between CC and local state [WPB-23452]#20515
thisisamir98 merged 1 commit intodevfrom
WPB-23452-2

Conversation

@thisisamir98
Copy link
Collaborator

@thisisamir98 thisisamir98 commented Feb 26, 2026

TaskWPB-23452 [Web] Implement recovery mechanism for epoch number mismatch between CC and local web state

Summary

if we read the epoch number from core crypto in case welcome is processed sooner than reset conversation will exists on core crypto but epoch number will be 0, on this scenario user will have a local unestablished MLS conversation that does exists on core crypto but with epoch number of 0. the recover for this scenario had the issue of reading the epoch number from backend (latest epoch number) hence app was trying to send MLS messages while the conversation was not established on core crypto level.

Closing #20508 with this.

@sonarqubecloud
Copy link

@thisisamir98 thisisamir98 requested a review from typfel February 26, 2026 14:57
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.36%. Comparing base (be04bfb) to head (bb8ffb1).
⚠️ Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
...epositories/conversation/ConversationRepository.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20515      +/-   ##
==========================================
- Coverage   45.38%   45.36%   -0.02%     
==========================================
  Files        1636     1636              
  Lines       40343    40344       +1     
  Branches     8330     8330              
==========================================
- Hits        18310    18304       -6     
- Misses      20099    20104       +5     
- Partials     1934     1936       +2     
Flag Coverage Δ
app_webapp 43.57% <0.00%> (-0.02%) ⬇️
lib_api_client 50.17% <ø> (ø)
lib_core 58.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...epositories/conversation/ConversationRepository.ts 49.10% <0.00%> (-0.04%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 9
  • Failed: 0
  • Skipped: 4
  • 🔁 Flaky: 1
  • 📊 Total: 14
  • Total Runtime: 136.2s (~ 2 min 16 sec)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)

@thisisamir98 thisisamir98 added this pull request to the merge queue Feb 26, 2026
Merged via the queue into dev with commit 6ae3161 Feb 26, 2026
56 checks passed
@thisisamir98 thisisamir98 deleted the WPB-23452-2 branch February 26, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants